Skip to content

fix: add error handler prop to components #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: add error handler prop to components #277

wants to merge 3 commits into from

Conversation

charmi-v
Copy link
Contributor

@charmi-v charmi-v commented Aug 21, 2024 •
edited
Loading

Description

Shared component containing error handlers with console.log

  • Icon
  • Image

Why

  • Added an onError prop to the shared component to handle errors from the parent component when the issue originates within the component.
  • This ensures that errors are communicated effectively to the user, rather than being overlooked, as might happen with a console log.

Issue

#148

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have commented my code, particularly in hard-to-understand areas

oyo
oyo requested changes Aug 22, 2024
View reviewed changes
Copy link

@oyo oyo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charmi-v we already have a snackbar management logic in the portal-frontend where the snackbars are managed in Redux:

https://github.com/eclipse-tractusx/portal-frontend/blob/main/src/features/control/notify.ts
https://github.com/eclipse-tractusx/portal-frontend/blob/main/src/services/NotifyService.ts
https://github.com/eclipse-tractusx/portal-frontend/blob/main/src/components/pages/Test/index.notify.tsx

I think a better solution is to pass a error or success handler function to the according shared components as props - this could be NotifyService.(error|success)

@charmi-v
Copy link
Contributor Author

charmi-v commented Aug 22, 2024 •
edited
Loading

@charmi-v we already have a snackbar management logic in the portal-frontend where the snackbars are managed in Redux:

https://github.com/eclipse-tractusx/portal-frontend/blob/main/src/features/control/notify.ts https://github.com/eclipse-tractusx/portal-frontend/blob/main/src/services/NotifyService.ts https://github.com/eclipse-tractusx/portal-frontend/blob/main/src/components/pages/Test/index.notify.tsx

I think a better solution is to pass a error or success handler function to the according shared components as props - this could be NotifyService.(error|success)

@oyo Thank you for highlighting that! I appreciate the context regarding the existing snackbar management in the portal-frontend.

  • Updated the existing components prop that might require on error handler

@charmi-v charmi-v marked this pull request as draft August 29, 2024 06:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@charmi-v charmi-v changed the title fix: add custom hook for error logging fix: added error handler prop to components Aug 29, 2024
@charmi-v charmi-v marked this pull request as ready for review August 29, 2024 07:37
@charmi-v charmi-v requested a review from oyo August 29, 2024 07:37
@MaximilianHauer MaximilianHauer added this to the Release 24.12 milestone Sep 13, 2024
@evegufy evegufy modified the milestones: Release 24.12, Release 25.03 Dec 2, 2024
@evegufy evegufy modified the milestones: Release 25.03, Release 25.06 Feb 12, 2025
@dhiren-singh-007 dhiren-singh-007 requested review from manojava-gk and saadanzari and removed request for oyo May 6, 2025 09:12
@evegufy evegufy changed the title fix: added error handler prop to components fix: add error handler prop to components May 7, 2025
@saadanzari
Copy link
Member

@charmi-v this looks good to me, we can merge this. please add the changelog entry.

@saadanzari saadanzari self-assigned this May 19, 2025
@saadanzari saadanzari requested a review from oyo May 19, 2025 09:46
@typecastcloud typecastcloud added the merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled label May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manojava-gk manojava-gk Awaiting requested review from manojava-gk

@saadanzari saadanzari Awaiting requested review from saadanzari

@oyo oyo Awaiting requested review from oyo

Requested changes must be addressed to merge this pull request.

Assignees

@oyo oyo

@saadanzari saadanzari

Labels
merge postponed the merge of this PR shall be postponed until all prerequisites are fulfilled
Projects
Portal
Status: IN PROGRESS
Milestone
Release 25.06
Development

Successfully merging this pull request may close these issues.
6 participants
@charmi-v @saadanzari @oyo @evegufy @typecastcloud @MaximilianHauer